Skip to content

Add configurator to strict typing#87279

Merged
frenck merged 3 commits into
home-assistant:devfrom
epenet:configurator
Feb 3, 2023
Merged

Add configurator to strict typing#87279
frenck merged 3 commits into
home-assistant:devfrom
epenet:configurator

Conversation

@epenet

@epenet epenet commented Feb 3, 2023

Copy link
Copy Markdown
Contributor

Proposed change

Linked to #87068
This adds type hints to all methods except request_config
request_config is more complex and will be adjusted in a follow-up preliminary PR: #87287

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant

home-assistant Bot commented Feb 3, 2023

Copy link
Copy Markdown
Contributor

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (configurator) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of configurator can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign configurator Removes the current integration label and assignees on the issue, add the integration domain after the command.

@epenet epenet marked this pull request as draft February 3, 2023 13:07
@epenet

epenet commented Feb 3, 2023

Copy link
Copy Markdown
Contributor Author

Marked as draft until #87287 is accepted to avoid merge conflict.
#87287 was merged

@epenet epenet marked this pull request as ready for review February 3, 2023 13:54
@epenet epenet changed the title Improve configurator type hints Add configurator to strict typing Feb 3, 2023

@frenck frenck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL, who would have thought we would ever see an improvement on the configurator (before it would be removed) 🤣

Thanks, @epenet 👍

../Frenck

@frenck frenck merged commit 923abdb into home-assistant:dev Feb 3, 2023
@epenet epenet deleted the configurator branch February 3, 2023 15:06
@epenet

epenet commented Feb 3, 2023

Copy link
Copy Markdown
Contributor Author

LOL, who would have thought we would ever see an improvement on the configurator (before it would be removed) 🤣

This one was easy - #87287 was the difficult one and it was blocking #87068

@github-actions github-actions Bot locked and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants